Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make conda package support multiple python versions #2227 #2247

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

marek-mihok
Copy link
Contributor

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

The problem was that the package only supports the version of python it was built in. It can be solved by specifying noarch: python inside meta.yaml conda config file. The result is the single platform independent package supporting multiple python versions.

Also update of the pipeline build action (amauryval/publish_conda_package_action) to version 2.0.3 is necessary, because it allows specifying noarch value as the Platforms parameter.

Closes #2227

mturoci
mturoci previously approved these changes Jan 31, 2024
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-mihok! We probably want to sync publish conda step in release-wave with publish-conda job as well.

@marek-mihok
Copy link
Contributor Author

We probably want to sync publish conda step in release-wave with publish-conda job as well.

@mturoci what is it used for? Is it for cases when you want to publish conda without going through all release process? It has no runs yet.

image

Also is CondaDir: 'py/conda' in publish-conda.yml instead of CondaDir: 'py/h2o_wave/conda' intentional?
And what exactly do you mean by "sync"?

@mturoci
Copy link
Collaborator

mturoci commented Jan 31, 2024

Is it for cases when you want to publish conda without going through all release process?

Yes.

is CondaDir: 'py/conda' in publish-conda.yml instead of CondaDir: 'py/h2o_wave/conda' intentional?

Probably not. Seems like a leftover, but better check.

And what exactly do you mean by "sync"?

They should be the same. No matter which workflow I use, I want the output to be identical.

@marek-mihok
Copy link
Contributor Author

@mturoci synced. Can we try to run publish-conda separately first to prevent release-wave from potential failing?

@mturoci mturoci merged commit 2b9eb00 into main Feb 1, 2024
2 checks passed
@mturoci mturoci deleted the feat/issue-2227 branch February 1, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda install works with python 3.11 only
2 participants